richard jarram
3e6a8cfbdb
docs(exercises): Updated challenge instructions for threads1.rs #closes 287
...
I've seen from a cursory glance on the repo that a lot of people
struggle with this problem set because of the ambiguity in the
instructions (See issues #287 , #743 , #567 ).
I'd like to recommend perhaps putting a TODO on the lines that need
changing to stop people from falling down rabbit holes and pursuing
completely different solution to the exercise that avoids the core
pedagogical content of the problem, which is an understanding of
how Arc is an atomic reference counting primitive that relies on
.lock() and .unwrap() to solve shared state concurrency problems
with the Mutex primitive.
I've also added comments in the instructions to highlight why it is that
the solution is solved when the program prints the counter to the screen
6 times, as this was unclear and was distracting students from the core
takeaway of the exercise.
2021-05-26 20:37:12 -07:00
marisa
a2f0401c4c
Merge pull request #762 from tlyu/move-semantics5-fixes
...
fix: move_semantics5 hints
2021-05-23 15:41:56 +02:00
Taylor Yu
1b85828548
fix: move_semantics5 hints
...
Improve the hints for move_semantics5, as well as the explanatory
comments in the code.
Previously, it was not clear what possible changes were allowed.
It seems that reordering the statements might be the intended solution.
The previous comment about not "adding newlines" doesn't make sense,
so treating it as "adding new lines" makes it more clear.
2021-05-22 22:09:58 -05:00
Taylor Yu
4c46e5e1a3
chore: minor typos in move_semantics5 hints
2021-05-22 21:56:14 -05:00
marisa
4da9e7ee29
Merge pull request #758 from rust-lang/all-contributors/add-sateeshkumarb
...
docs: add sateeshkumarb as a contributor
2021-05-17 14:11:15 +02:00
allcontributors[bot]
72e615aa7a
docs: update .all-contributorsrc [skip ci]
2021-05-17 12:11:05 +00:00
allcontributors[bot]
cd02abc481
docs: update README.md [skip ci]
2021-05-17 12:11:04 +00:00
Sateesh
399ab328d8
feat: Add move_semantics5 exercise. ( #746 )
...
* feat: Add move_semantics5 exercise.
* feat: Add option3 exercise
* Address review comments. Fix typos, sentence formatting.
* Remove unwanted newline.
* Address review comments: make comment inline, fix format in print.
2021-05-17 14:10:40 +02:00
marisa
809ec2ce01
Merge pull request #755 from tlyu/dyn-error-hints
...
fix(try_from_into, from_str): hints for dyn Error
2021-05-17 14:09:44 +02:00
Taylor Yu
11d2cf0d60
fix(try_from_into, from_str): hints for dyn Error
...
Add hints about how to return the correct type for functions that
return `Result<_, Box<dyn Error>`. Some feedback from Discord suggests
that people run into trouble with that.
2021-05-15 14:01:17 -05:00
marisa
dbb2624403
Merge pull request #751 from juanprq/main
...
fix: remove trailing whitespace
2021-05-13 17:20:47 +02:00
Juan Pablo Ramirez
4d4fa77459
fix: remove trailing whitespaces from iterators1
2021-05-12 10:20:07 -05:00
Juan Pablo Ramirez
3145794084
fix: add hints to generics1 and generics2 exercises
2021-05-11 14:50:05 -05:00
Juan Pablo Ramirez
d9b69bd1a0
fix: remove trailing whitespace
2021-05-09 17:58:54 -05:00
marisa
7cd635fa84
Merge pull request #740 from rust-lang/all-contributors/add-PiDelport
...
docs: add PiDelport as a contributor
2021-05-01 12:12:51 +02:00
allcontributors[bot]
ce40e201f0
docs: update .all-contributorsrc [skip ci]
2021-05-01 10:12:43 +00:00
allcontributors[bot]
404f3ef465
docs: update README.md [skip ci]
2021-05-01 10:12:42 +00:00
marisa
e1be594fdd
Merge pull request #739 from PiDelport/patch-1
...
style(standard_library_types): stray line break
2021-05-01 12:12:29 +02:00
Pi Delport
9569c9a9e7
style(standard_library_types): stray line break
2021-04-29 23:31:26 +02:00
marisa
91530f5716
Merge pull request #736 from maartentibau/quiz1_add_explicit_test_40
...
chore: Update quiz1.rs add explicit test for 40
2021-04-27 10:20:50 +02:00
Maarten Tibau
650b1dee54
chore: Update quiz1.rs add explicit test for 40
2021-04-25 19:02:50 +02:00
marisa
6b6dc9dd48
Merge pull request #731 from rust-lang/all-contributors/add-stoiandan
...
docs: add stoiandan as a contributor
2021-04-24 17:36:48 +02:00
allcontributors[bot]
3a9ec4192d
docs: update .all-contributorsrc [skip ci]
2021-04-24 15:36:39 +00:00
allcontributors[bot]
4f7dbbd2c3
docs: update README.md [skip ci]
2021-04-24 15:36:38 +00:00
marisa
8c37db1a23
Merge pull request #730 from stoiandan/main
...
updated README.md; specify need for admin rights
2021-04-24 17:36:19 +02:00
Dan Stoian
c6b7ad8878
updated README.md; specify need for admin rights
2021-04-24 18:32:13 +03:00
mokou
84461c20cb
release: 4.4.0
2021-04-24 11:57:00 +02:00
marisa
3cddda56fc
Merge pull request #725 from Zerotask/add-hint-corresponding-readme
...
chore(watch): add hint for the exercises README.md
2021-04-24 11:46:25 +02:00
marisa
37f3069a67
Merge pull request #724 from Zerotask/update-dependencies
...
chore(deps): update cargo dependencies
2021-04-24 11:45:56 +02:00
marisa
2b2fbe918e
Merge pull request #723 from Zerotask/update-exercises-readme
...
docs(exercises): consistent excersises README.md files
2021-04-24 11:45:37 +02:00
Zerotask
cf42ddc449
chore(watch): add hint for the exercises README.md
...
rustlings watch will now show an additional hint for the corresponding README.me
2021-04-23 20:28:55 +02:00
Zerotask
eefa656232
chore(deps): update cargo dependencies
2021-04-23 20:07:32 +02:00
Zerotask
249ad44cc0
docs(exercises): updated all exercises readme files
...
all exercises readme files now have a unified structure and a description
2021-04-23 19:54:31 +02:00
marisa
54804e344d
Merge pull request #721 from Zerotask/add-further-help-for-generics3
...
docs(generics): add bounds help
2021-04-23 15:05:00 +02:00
marisa
1c334de6fd
Merge pull request #718 from Zerotask/add-further-help-to-error-excersis
...
docs(errors): add additional help for Result/Boxing
2021-04-23 15:04:47 +02:00
Zerotask
f253103a31
docs(generics): add bounds help
...
add help for bounds provided by the rust by example book
2021-04-22 22:11:04 +02:00
Zerotask
1120db57a6
docs(errors): add additional help for Result/Boxing
...
add additional help information provided by the rust by example book
2021-04-22 21:32:29 +02:00
marisa
afa661cff4
Merge pull request #715 from rust-lang/feat/declap
...
feat: Replace clap with argh
2021-04-21 16:33:07 +02:00
mokou
347f30bd86
fix(main): Let find_exercise work with borrows
2021-04-21 16:21:56 +02:00
marisa
127773f3f5
Merge pull request #717 from rust-lang/all-contributors/add-bmacer
...
docs: add bmacer as a contributor
2021-04-21 14:50:37 +02:00
allcontributors[bot]
8d0490bd70
docs: update .all-contributorsrc [skip ci]
2021-04-21 12:50:27 +00:00
allcontributors[bot]
293dfb35d5
docs: update README.md [skip ci]
2021-04-21 12:50:26 +00:00
Brandon Macer
81be404487
feat(arc1): Add more details to description and hint ( #710 )
...
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
2021-04-21 14:50:03 +02:00
mokou
6177b6e126
chore: Fix integration tests
2021-04-21 14:47:53 +02:00
marisa
79cc657917
Merge pull request #646 from apogeeoak/iterator
...
Added iterators5.rs exercise.
2021-04-21 10:10:50 +02:00
mokou
7928122fce
feat: Replace clap with argh
...
I’ve been wanting to do this for a while, but always procrastinated on it. We’ve been using Clap since the 2.0 rewrite, but Clap is known to be a fairly heavy library. Since Rustlings is usually peoples’ first contact with a Rust compilation, I think it’s in our best interests that this complation is as fast as possible. In effect, replacing Clap with the smaller, structopt-style `argh` reduces the amount of crates needing to be compiled from 82 to 60.
I also think this makes the code way easier to read, we don’t need to use Clap’s methods anymore, but can switch over to using pure Rust methods, e.g., switches are booleans, options are Option<String>s or the like, and subcommands are just structs.
2021-04-21 10:08:26 +02:00
apogeeoak
9c88ea9126
Improved iterators5.rs explanation.
2021-04-20 18:55:04 -04:00
marisa
2b766ef9f9
Merge pull request #648 from apogeeoak/iterator2
...
Moved iterators2.rs errors out of tests.
2021-04-20 11:24:10 +02:00
marisa
bd3d9ac9d5
Merge pull request #649 from apogeeoak/iterator3
...
Enabled iterators3.rs to run without commented out tests.
2021-04-20 11:22:39 +02:00
marisa
aa0db8379c
Merge pull request #714 from rust-lang/all-contributors/add-hongshaoyang
...
docs: add hongshaoyang as a contributor
2021-04-20 11:19:49 +02:00
