From e1fdfbb062e655b8cb4ddb770abe3f13cc606ec3 Mon Sep 17 00:00:00 2001
From: "allcontributors[bot]"
<46447321+allcontributors[bot]@users.noreply.github.com>
Date: Fri, 9 Oct 2020 00:15:53 +0000
Subject: [PATCH 1/9] docs: update README.md [skip ci]
---
README.md | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index efad42b..3433e8e 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[](#contributors-)
+[](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->
# rustlings 🦀❤️ [](https://buildkite.com/mokou/rustlings)
@@ -226,6 +226,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center"><a href="https://github.com/GaurangTandon"><img src="https://avatars1.githubusercontent.com/u/6308683?v=4" width="100px;" alt=""/><br /><sub><b>Gaurang Tandon</b></sub></a><br /><a href="#content-GaurangTandon" title="Content">🖋</a></td>
<td align="center"><a href="https://github.com/dev-cyprium"><img src="https://avatars1.githubusercontent.com/u/6002628?v=4" width="100px;" alt=""/><br /><sub><b>Stefan Kupresak</b></sub></a><br /><a href="#content-dev-cyprium" title="Content">🖋</a></td>
<td align="center"><a href="https://github.com/greg-el"><img src="https://avatars3.githubusercontent.com/u/45019882?v=4" width="100px;" alt=""/><br /><sub><b>Greg Leonard</b></sub></a><br /><a href="#content-greg-el" title="Content">🖋</a></td>
+ <td align="center"><a href="https://ryanpcmcquen.org"><img src="https://avatars3.githubusercontent.com/u/772937?v=4" width="100px;" alt=""/><br /><sub><b>Ryan McQuen</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/commits?author=ryanpcmcquen" title="Code">💻</a></td>
</tr>
</table>
From 29dd0b1e410715fee8b18eee54da67405d2c0625 Mon Sep 17 00:00:00 2001
From: "allcontributors[bot]"
<46447321+allcontributors[bot]@users.noreply.github.com>
Date: Fri, 9 Oct 2020 00:15:54 +0000
Subject: [PATCH 2/9] docs: update .all-contributorsrc [skip ci]
---
.all-contributorsrc | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/.all-contributorsrc b/.all-contributorsrc
index 98a7e9f..92c3af8 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -591,6 +591,15 @@
"contributions": [
"content"
]
+ },
+ {
+ "login": "ryanpcmcquen",
+ "name": "Ryan McQuen",
+ "avatar_url": "https://avatars3.githubusercontent.com/u/772937?v=4",
+ "profile": "https://ryanpcmcquen.org",
+ "contributions": [
+ "code"
+ ]
}
],
"contributorsPerLine": 8,
From 18e0bfef1de53071e353ba1ec5837002ff7290e6 Mon Sep 17 00:00:00 2001
From: Ryan McQuen <rpcm@linux.com>
Date: Sat, 10 Oct 2020 04:11:57 -0700
Subject: [PATCH 3/9] fix(quiz3): Second test is for odd numbers, not even.
(#553)
---
exercises/tests/tests3.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exercises/tests/tests3.rs b/exercises/tests/tests3.rs
index 06cf7ea..3424f94 100644
--- a/exercises/tests/tests3.rs
+++ b/exercises/tests/tests3.rs
@@ -20,7 +20,7 @@ mod tests {
}
#[test]
- fn is_false_when_even() {
+ fn is_false_when_odd() {
assert!();
}
}
From 2b1fb2b739bf9ad8d6b7b12af25fee173011bfc4 Mon Sep 17 00:00:00 2001
From: Axel Viala <axel.viala@darnuria.eu>
Date: Sat, 10 Oct 2020 16:04:19 +0200
Subject: [PATCH 4/9] feat(primitive_types6): Add a test (#548)
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
---
exercises/primitive_types/primitive_types6.rs | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/exercises/primitive_types/primitive_types6.rs b/exercises/primitive_types/primitive_types6.rs
index 2bc817e..5c6c5a4 100644
--- a/exercises/primitive_types/primitive_types6.rs
+++ b/exercises/primitive_types/primitive_types6.rs
@@ -1,11 +1,16 @@
// primitive_types6.rs
// Use a tuple index to access the second element of `numbers`.
-// You can put this right into the `println!` where the ??? is.
+// You can put the expression for the second element where ??? is so that the test passes.
// Execute `rustlings hint primitive_types6` for hints!
// I AM NOT DONE
-fn main() {
+#[test]
+fn indexing_tuple() {
let numbers = (1, 2, 3);
- println!("The second number is {}", ???);
+ /// Replace below ??? with the tuple indexing syntax.
+ let second = ???;
+
+ assert_eq!(2, second
+ "This is not the 2nd number in the tuple!")
}
From ded1474bbb05870beac061f1bdac26ef98035d0d Mon Sep 17 00:00:00 2001
From: "allcontributors[bot]"
<46447321+allcontributors[bot]@users.noreply.github.com>
Date: Sat, 10 Oct 2020 16:07:15 +0200
Subject: [PATCH 5/9] docs: add darnuria as a contributor (#554)
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
---
.all-contributorsrc | 9 +++++++++
README.md | 5 ++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/.all-contributorsrc b/.all-contributorsrc
index 92c3af8..8bec240 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -600,6 +600,15 @@
"contributions": [
"code"
]
+ },
+ {
+ "login": "darnuria",
+ "name": "Axel Viala",
+ "avatar_url": "https://avatars1.githubusercontent.com/u/2827553?v=4",
+ "profile": "https://darnuria.eu",
+ "contributions": [
+ "code"
+ ]
}
],
"contributorsPerLine": 8,
diff --git a/README.md b/README.md
index 3433e8e..1e4e953 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
-[](#contributors-)
+[](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->
# rustlings 🦀❤️ [](https://buildkite.com/mokou/rustlings)
@@ -228,6 +228,9 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center"><a href="https://github.com/greg-el"><img src="https://avatars3.githubusercontent.com/u/45019882?v=4" width="100px;" alt=""/><br /><sub><b>Greg Leonard</b></sub></a><br /><a href="#content-greg-el" title="Content">🖋</a></td>
<td align="center"><a href="https://ryanpcmcquen.org"><img src="https://avatars3.githubusercontent.com/u/772937?v=4" width="100px;" alt=""/><br /><sub><b>Ryan McQuen</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/commits?author=ryanpcmcquen" title="Code">💻</a></td>
</tr>
+ <tr>
+ <td align="center"><a href="https://darnuria.eu"><img src="https://avatars1.githubusercontent.com/u/2827553?v=4" width="100px;" alt=""/><br /><sub><b>Axel Viala</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/commits?author=darnuria" title="Code">💻</a></td>
+ </tr>
</table>
<!-- markdownlint-enable -->
From cc5b9b772a219cc114a31e762bdf0eaa63cb3221 Mon Sep 17 00:00:00 2001
From: "allcontributors[bot]"
<46447321+allcontributors[bot]@users.noreply.github.com>
Date: Sat, 10 Oct 2020 17:08:22 +0200
Subject: [PATCH 6/9] docs: add AnnikaCodes as a contributor (#557)
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
---
.all-contributorsrc | 9 +++++++++
README.md | 1 +
2 files changed, 10 insertions(+)
diff --git a/.all-contributorsrc b/.all-contributorsrc
index 8bec240..56e4d53 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -601,6 +601,15 @@
"code"
]
},
+ {
+ "login": "AnnikaCodes",
+ "name": "Annika",
+ "avatar_url": "https://avatars3.githubusercontent.com/u/56906084?v=4",
+ "profile": "https://github.com/AnnikaCodes",
+ "contributions": [
+ "review"
+ ]
+ },
{
"login": "darnuria",
"name": "Axel Viala",
diff --git a/README.md b/README.md
index 1e4e953..a618abb 100644
--- a/README.md
+++ b/README.md
@@ -229,6 +229,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center"><a href="https://ryanpcmcquen.org"><img src="https://avatars3.githubusercontent.com/u/772937?v=4" width="100px;" alt=""/><br /><sub><b>Ryan McQuen</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/commits?author=ryanpcmcquen" title="Code">💻</a></td>
</tr>
<tr>
+ <td align="center"><a href="https://github.com/AnnikaCodes"><img src="https://avatars3.githubusercontent.com/u/56906084?v=4" width="100px;" alt=""/><br /><sub><b>Annika</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/pulls?q=is%3Apr+reviewed-by%3AAnnikaCodes" title="Reviewed Pull Requests">👀</a></td>
<td align="center"><a href="https://darnuria.eu"><img src="https://avatars1.githubusercontent.com/u/2827553?v=4" width="100px;" alt=""/><br /><sub><b>Axel Viala</b></sub></a><br /><a href="https://github.com/rust-lang/rustlings/commits?author=darnuria" title="Code">💻</a></td>
</tr>
</table>
From e6bde22f9c65e1da07602021d759ab702f7317d4 Mon Sep 17 00:00:00 2001
From: Rastamo <42067541+Rastamo@users.noreply.github.com>
Date: Sun, 11 Oct 2020 14:00:03 +0200
Subject: [PATCH 7/9] chore: primitive_types6 mode changed to test (#559)
primitive_types6 exercise was changed to test yesterday, but info.toml file wasn't updated.
I think this change should fix it.
---
info.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/info.toml b/info.toml
index 28bf24d..2d0abdb 100644
--- a/info.toml
+++ b/info.toml
@@ -210,7 +210,7 @@ of the tuple. You can do it!!"""
[[exercises]]
name = "primitive_types6"
path = "exercises/primitive_types/primitive_types6.rs"
-mode = "compile"
+mode = "test"
hint = """
While you could use a destructuring `let` for the tuple here, try
indexing into it instead, as explained in the last example of the
From 4fb230daf1251444fcf29e085cee222a91f8a37e Mon Sep 17 00:00:00 2001
From: Matthew Smillie <mbs@tmkf.local>
Date: Tue, 13 Oct 2020 23:18:41 -0700
Subject: [PATCH 8/9] fix(primitive_types6): missing comma in test
---
exercises/primitive_types/primitive_types6.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exercises/primitive_types/primitive_types6.rs b/exercises/primitive_types/primitive_types6.rs
index 5c6c5a4..0fa42b2 100644
--- a/exercises/primitive_types/primitive_types6.rs
+++ b/exercises/primitive_types/primitive_types6.rs
@@ -11,6 +11,6 @@ fn indexing_tuple() {
/// Replace below ??? with the tuple indexing syntax.
let second = ???;
- assert_eq!(2, second
+ assert_eq!(2, second,
"This is not the 2nd number in the tuple!")
}
From 472d8592d65c8275332a20dfc269e7ac0d41bc88 Mon Sep 17 00:00:00 2001
From: Matthew Smillie <mbs@tmkf.local>
Date: Tue, 13 Oct 2020 23:20:17 -0700
Subject: [PATCH 9/9] fix(primitive_types6): remove 'unused doc comment'
warning
---
exercises/primitive_types/primitive_types6.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exercises/primitive_types/primitive_types6.rs b/exercises/primitive_types/primitive_types6.rs
index 0fa42b2..b8c9b82 100644
--- a/exercises/primitive_types/primitive_types6.rs
+++ b/exercises/primitive_types/primitive_types6.rs
@@ -8,7 +8,7 @@
#[test]
fn indexing_tuple() {
let numbers = (1, 2, 3);
- /// Replace below ??? with the tuple indexing syntax.
+ // Replace below ??? with the tuple indexing syntax.
let second = ???;
assert_eq!(2, second,